maskit commented on code in PR #9482: URL: https://github.com/apache/trafficserver/pull/9482#discussion_r1251376986
########## iocore/net/I_NetVConnection.h: ########## @@ -857,7 +857,20 @@ class NetVConnection : public VConnection, public PluginUserArgs<TS_USER_ARGS_VC bool has_proxy_protocol(IOBufferReader *); bool has_proxy_protocol(char *, int64_t *); + template <typename S> S *get_service() const; + Review Comment: I made the change as suggested but actually I don't like either place. Although forward declaration does not bring dependency, the class names have to be on this header file. Now the header file know of the concrete classes. This is the reason I didn't have these helper functions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
