ywkaras commented on code in PR #10680:
URL: https://github.com/apache/trafficserver/pull/10680#discussion_r1373678154
##########
cmake/Check128BitCas.cmake:
##########
@@ -25,18 +25,16 @@
set(CHECK_PROGRAM
"
- int
- main()
+ int main(void)
{
__int128_t x = 0;
- __sync_bool_compare_and_swap(&x,0,10);
-
- return 0;
+ return __sync_bool_compare_and_swap(&x,0,10);
Review Comment:
Not sure the sample code really needs to change at all. Pedantic C doesn't
allow nothing between the braces when declaring a function. Some compilers
might warn about ignoring the return value of __sync_bool_compare_and_swap().
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
