JosiahWI commented on PR #10680:
URL: https://github.com/apache/trafficserver/pull/10680#issuecomment-1781767003

   > I think the bug here is line 45:
   > 
   > ```
   > set(CMAKE_REQUIRED_FLAGS "-Werror" "-mcx16")
   > ```
   > 
   > needs to be:
   > 
   > ```
   > set(CMAKE_REQUIRED_FLAGS "-Werror -mcx16")
   > ```
   
   I would expect this to introduce a bug. The flags should be a list, so in 
CMake it should be semicolon-seperated, not space-separated, or am I missing 
something obvious here?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to