cmcfarlen commented on PR #10680: URL: https://github.com/apache/trafficserver/pull/10680#issuecomment-1783302522
> > String of additional flags to pass to the compiler. The string must be space-delimited--a [;-list](https://cmake.org/cmake/help/latest/manual/cmake-language.7.html#cmake-language-lists) will not work. The contents of [CMAKE__FLAGS](https://cmake.org/cmake/help/latest/variable/CMAKE_LANG_FLAGS.html#variable:CMAKE_%3CLANG%3E_FLAGS) and its associated configuration-specific variable are automatically added to the compiler command before the contents of CMAKE_REQUIRED_FLAGS. > > `CMAKE_REQUIRED_FLAGS` doesn't take a list - every other variable in the module does. Yay for inconsistent APIs. Thanks for the fix @cmcfarlen! yeah, I was surprised by this when I looked at the cmake log. It just silently ignores anything past the first argument... I did test this way and it worked with the space. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
