bneradt commented on code in PR #10696:
URL: https://github.com/apache/trafficserver/pull/10696#discussion_r1378345366
##########
src/iocore/net/ConnectionTracker.cc:
##########
@@ -139,37 +143,54 @@ Config_Update_Conntrack_Alert_Delay(const char *name,
RecDataT dtype, RecData da
} // namespace
void
-OutboundConnTrack::config_init(GlobalConfig *global, TxnConfig *txn)
+ConnectionTracker::config_init(GlobalConfig *global, TxnConfig *txn)
{
_global_config = global; // remember this for later retrieval.
// Per transaction lookup must be done at call time
because it changes.
- Enable_Config_Var(CONFIG_VAR_MIN, &Config_Update_Conntrack_Min, txn);
- Enable_Config_Var(CONFIG_VAR_MAX, &Config_Update_Conntrack_Max, txn);
- Enable_Config_Var(CONFIG_VAR_MATCH, &Config_Update_Conntrack_Match, txn);
- Enable_Config_Var(CONFIG_VAR_ALERT_DELAY,
&Config_Update_Conntrack_Alert_Delay, global);
+ Enable_Config_Var(CONFIG_SERVER_VAR_MIN, &Config_Update_Conntrack_Min, txn);
+ Enable_Config_Var(CONFIG_SERVER_VAR_MAX, &Config_Update_Conntrack_Max, txn);
+ Enable_Config_Var(CONFIG_SERVER_VAR_MATCH, &Config_Update_Conntrack_Match,
txn);
+ Enable_Config_Var(CONFIG_SERVER_VAR_ALERT_DELAY,
&Config_Update_Conntrack_Alert_Delay, global);
+}
+
+ConnectionTracker::TxnState
+ConnectionTracker::obtain_inbound(IpEndpoint const &addr)
Review Comment:
Right, that makes sense. I teased this PR out after doing them as one PR and
I didn't remove everything perfectly from this base one.
I've updated the PR now to not include obtain_inbound and I reverted some of
the comment changes too. I skimmed through the ConnectionTracker.{cc,h} files
and I think I got everything that was "new" out of it, but let me know if I
missed anything.
Thanks for reviewing!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
