bneradt commented on code in PR #10696: URL: https://github.com/apache/trafficserver/pull/10696#discussion_r1379000819
########## plugins/experimental/tls_bridge/tls_bridge.cc: ########## @@ -21,7 +21,7 @@ #include "ts/ts.h" #include "swoc/TextView.h" -#include "regex.h" +#include "tscore/Regex.h" Review Comment: Yes. This is a symptom of the bigger problem that tsl_bridge is relying upon tscore. This regex that was in there was copied and pasted, and moving things around resulting in the linker seeing duplicate symbols for that regex. Since this relies upon tscore anyway (it was already linking into that before this PR), it made sense to address the errors by removing the copied code. We can address tls_bridge core dependency in a separate PR. I filed a separate ticket for this issue: #10707 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
