SolidWallOfCode commented on code in PR #10696: URL: https://github.com/apache/trafficserver/pull/10696#discussion_r1378974185
########## plugins/experimental/tls_bridge/tls_bridge.cc: ########## @@ -21,7 +21,7 @@ #include "ts/ts.h" #include "swoc/TextView.h" -#include "regex.h" +#include "tscore/Regex.h" Review Comment: I really don't like this - it's cheating once again and creating future problems. If someone is writing a TLS bridge or variant, that plugin isn't permitted to do this, that is grab a file out of "tscore". TLS Bridge was written to be a useful example and this really diminishes that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
