freak82 opened a new pull request, #11382: URL: https://github.com/apache/trafficserver/pull/11382
The signature of the function in question is ``` void Http2CommonSession::add_url_to_pushed_table(const char *url, int url_len) ``` The given `url` is used when emplacing/inserting to `_h2_pushed_urls` collection but the given `url_len` is not used and this may change the actually inserted URL because it'll search for the `\0` terminator instead of inserting only `url_len` characters/bytes. And the `\0` terminator may not even be present in some cases (the `TSHttpTxnServerPush` calls the above function i.e. it may be called by different plugins). I've opened [this issue](https://github.com/apache/trafficserver/issues/11375) about this and it resulted in this pull request. Note that the problem with `url_len` is reported by the compiler if/when the warning for unused parameters is enabled. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
