freak82 commented on PR #11382: URL: https://github.com/apache/trafficserver/pull/11382#issuecomment-2125104401
My bad. I'm not very accustomed to this pattern yet. Do you think I should add the `sdk_assert` in `TSHttpTxnServerPush` or I should add the check with the `if (len < 0) len = strlen(...)`? I'm asking because the `TSHttpTxnServerPush` function calls ``` url_obj.parse(url, url_len); ``` and the `url_obj` also does this check internally i.e. it's prepared for `-1` length and thus maybe the it's expected that `TSHttpTxnServerPush` can also take `-1` length and should be able to handle it instead of asserting. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
