ywkaras commented on PR #11382: URL: https://github.com/apache/trafficserver/pull/11382#issuecomment-2124912526
Good find! It looks like `add_url_to_pushed_table` is only used in `TSHttpTxnServerPush` (in `src/api/InkAPI.cc`). As a part of this PR, I suggest you add `sdk_assert(url && url_len > 0)` in `TSHttpTxnServerPush`. Some TS API functions that accept strings with lengths work like this: https://github.com/apache/trafficserver/blob/4f74b0222b5f6b77cf7a39a56bc8807595c35bc9/src/api/InkAPI.cc#L1292 So, someone might assume they can pass `-1` as the length. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
