zwoop commented on PR #11865: URL: https://github.com/apache/trafficserver/pull/11865#issuecomment-2477669333
> Would it make sense to remove the `cache_config_` global for this, or mark it const? The purposes seem to be redundant to me. Well, I don't think we can (easily) eliminate cache_config_target_fragment_size, it's a reloadable configuration, and it has to have a "destination" to write to in the callback. What we could do is to simplify target_fragment_size() by always setting the StripeSMs size to either cache_config_target_fragment_size or the volume.config specified value. Since the cache is a bit of a mystery, I was worried about making too many changes ... But I could do this one (it avoids a "comparison" at runtime). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
