JosiahWI commented on code in PR #11865:
URL: https://github.com/apache/trafficserver/pull/11865#discussion_r1843038143
##########
src/iocore/cache/Stripe.h:
##########
@@ -115,7 +117,7 @@ class Stripe
*
* @see START_POS
*/
- Stripe(CacheDisk *disk, off_t blocks, off_t dir_skip, int avg_obj_size = -1);
+ Stripe(CacheDisk *disk, off_t blocks, off_t dir_skip, int avg_obj_size = -1,
int fragment_size = -1);
Review Comment:
This could make take the vol config directly, especially if we are likely to
add more configuration parameters in the future.
##########
src/iocore/cache/StripeSM.h:
##########
@@ -168,7 +168,7 @@ class StripeSM : public Continuation, public Stripe
*
* @see START_POS
*/
- StripeSM(CacheDisk *disk, off_t blocks, off_t dir_skip, int avg_obj_size =
-1);
+ StripeSM(CacheDisk *disk, off_t blocks, off_t dir_skip, int avg_obj_size =
-1, int fragment_size = -1);
Review Comment:
Looks like the docstring is out of date.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
