JosiahWI commented on code in PR #11865:
URL: https://github.com/apache/trafficserver/pull/11865#discussion_r1843043114
##########
src/iocore/cache/Stripe.h:
##########
@@ -115,7 +117,7 @@ class Stripe
*
* @see START_POS
*/
- Stripe(CacheDisk *disk, off_t blocks, off_t dir_skip, int avg_obj_size = -1);
+ Stripe(CacheDisk *disk, off_t blocks, off_t dir_skip, int avg_obj_size = -1,
int fragment_size = -1);
Review Comment:
On second thought, that may not be great, because each config is used for an
entire cache span (volume), so the dependencies would get messier. I think it'd
be nice to have a config type for stripes at some point, which could maybe be
part of the volume config, but let's leave it as is for now.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
