cmcfarlen commented on PR #12201:
URL: https://github.com/apache/trafficserver/pull/12201#issuecomment-2835881366
Hi! This doesn't compile for me. I added a line to
`include/tscore/ink_config.cmake.in` so `HAVE_ZSTD_H` would be truthy for the
CPP macros. This lit up that code, but then there were several compiler errors:
```
/Users/cmcfarlen/projects/oss/trafficserver/plugins/compress/compress.cc:203:9:
error: no member named 'zstd_ctx' in 'Data'; did you mean 'zstd_cctx'?
203 | data->zstd_ctx = nullptr;
| ^~~~~~~~
| zstd_cctx
/Users/cmcfarlen/projects/oss/trafficserver/plugins/compress/misc.h:93:14:
note: 'zstd_cctx' declared here
93 | ZSTD_CCtx *zstd_cctx;
| ^
/Users/cmcfarlen/projects/oss/trafficserver/plugins/compress/compress.cc:206:11:
error: no member named 'zstd_ctx' in 'Data'; did you mean 'zstd_cctx'?
206 | data->zstd_ctx = ZSTD_createCCtx();
| ^~~~~~~~
| zstd_cctx
/Users/cmcfarlen/projects/oss/trafficserver/plugins/compress/misc.h:93:14:
note: 'zstd_cctx' declared here
93 | ZSTD_CCtx *zstd_cctx;
| ^
/Users/cmcfarlen/projects/oss/trafficserver/plugins/compress/compress.cc:207:16:
error: no member named 'zstd_ctx' in 'Data'; did you mean 'zstd_cctx'?
207 | if (!data->zstd_ctx) {
| ^~~~~~~~
| zstd_cctx
/Users/cmcfarlen/projects/oss/trafficserver/plugins/compress/misc.h:93:14:
note: 'zstd_cctx' declared here
93 | ZSTD_CCtx *zstd_cctx;
| ^
```
Please include this patch in your PR to enable the ZSTD code. Thanks!
```
diff --git a/include/tscore/ink_config.h.cmake.in
b/include/tscore/ink_config.h.cmake.in
index 634ed94c3..7da0771fd 100644
--- a/include/tscore/ink_config.h.cmake.in
+++ b/include/tscore/ink_config.h.cmake.in
@@ -184,3 +184,5 @@ const int DEFAULT_STACKSIZE = @DEFAULT_STACK_SIZE@;
#cmakedefine YAMLCPP_LIB_VERSION "@YAMLCPP_LIB_VERSION@"
#cmakedefine01 TS_HAS_CRIPTS
+
+#cmakedefine HAVE_ZSTD_H 1
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
