JosiahWI commented on code in PR #12201:
URL: https://github.com/apache/trafficserver/pull/12201#discussion_r2280699295
##########
CMakeLists.txt:
##########
@@ -341,6 +341,11 @@ set(TS_USE_MALLOC_ALLOCATOR ${ENABLE_MALLOC_ALLOCATOR})
set(TS_USE_ALLOCATOR_METRICS ${ENABLE_ALLOCATOR_METRICS})
find_package(ZLIB REQUIRED)
+find_package(zstd)
+if(zstd_FOUND)
+ set(HAVE_ZSTD_H TRUE)
+endif()
Review Comment:
This is probably fine, but it does leave `HAVE_ZSTD_H` unset if the
condition is false. What do you think about the following?
```suggestion
set(HAVE_ZSTD_H ${zstd_FOUND})
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
