JosiahWI commented on code in PR #12201:
URL: https://github.com/apache/trafficserver/pull/12201#discussion_r2280701768


##########
include/tscore/ink_config.h.cmake.in:
##########
@@ -187,3 +187,5 @@ const int DEFAULT_STACKSIZE = @DEFAULT_STACK_SIZE@;
 #cmakedefine YAMLCPP_LIB_VERSION "@YAMLCPP_LIB_VERSION@"
 
 #cmakedefine01 TS_HAS_CRIPTS
+
+#cmakedefine HAVE_ZSTD_H 1

Review Comment:
   I think this should be `TS_USE_ZSTD` for consistency with the other optional 
features and be grouped with them in this file. @cmcfarlen the other optional 
feature defines use `#cmakedefine01`, should this one as well?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to