grahamsedman commented on PR #13187:
URL: https://github.com/apache/trafficserver/pull/13187#issuecomment-4547635059
Hi,
The reason for the 2k code changes is due to I formatted the file with clang
format and it has been committed not been well formatted, so I fixed it.
The constructor code block section near the top of the file is the place to
look and the current version on github look at this code block starting at line
1121.
```
// === TextView Implementation ===
/// @cond TextView_INTERNAL
// Doxygen doesn't match these up well due to various type and template
issues.
// @internal If there is more than one overload for numeric types, it's easy
to get ambiguity. The only
// fix, unfortunately, is lots of overloads to cover the ambiguous cases.
inline constexpr TextView::TextView(const char *ptr, size_t n) noexcept
: super_type(ptr, n == npos ? (ptr ? ::strlen(ptr) : 0) : n) {}
inline constexpr TextView::TextView(const char *ptr, unsigned n) noexcept :
super_type(ptr, size_t(n)) {}
inline constexpr TextView::TextView(const char *ptr, ssize_t n) noexcept
: super_type(ptr, n < 0 ? (ptr ? ::strlen(ptr) : 0) : size_t(n)) {}
inline constexpr TextView::TextView(const char *ptr, int n) noexcept
: super_type(ptr, n < 0 ? (ptr ? ::strlen(ptr) : 0) : size_t(n)) {}
inline constexpr TextView::TextView(std::nullptr_t) noexcept :
super_type(nullptr, 0) {}
inline TextView::TextView(std::string const &str) noexcept : super_type(str)
{}
inline constexpr TextView::TextView(super_type const &that) noexcept :
super_type(that) {}
template <size_t N> constexpr TextView::TextView(const char (&s)[N])
noexcept : super_type(s, s[N - 1] ? N : N - 1) {}
template <typename C, typename> constexpr TextView::TextView(C const &c) :
super_type(c.data(), c.size()) {}
```
As explained I removed some code to make it compile and it does after fixing
this issue. Clangd lints this error too.
Regards
Graham
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
