grahamsedman commented on PR #13187: URL: https://github.com/apache/trafficserver/pull/13187#issuecomment-4670119391
Hi @JosiahWI, Thanks for the clarification. Before doing any further work on this PR, I think we need to resolve some uncertainty around the ownership and maintenance location of `libswoc`. My investigation found that the code currently exists in multiple places: * Original `libswoc` repository (largely inactive for several years) * Apache's actively maintained external `trafficserver-libswoc` repository * The vendored copy under `ATS/lib/swoc`, which appears to have diverged from the external repository Because of that, I'd prefer not to make additional changes directly against the vendored copy until we understand which repository is intended to be the authoritative source for this code and how updates are expected to flow between them. I'll review the Copilot comments, but some of the requested changes may be better addressed in the actively maintained external `trafficserver-libswoc` repository and then synced into ATS, rather than making further ad hoc modifications in the vendored copy. Could we first confirm the expected maintenance path for `libswoc` before I proceed with additional changes. Looking to know if `libswoc` the vendored copy should be a sub-module to the external `trafficserver-libswoc`. When I know this I will follow this for this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
