masaori335 commented on code in PR #13231:
URL: https://github.com/apache/trafficserver/pull/13231#discussion_r3346543467
##########
include/ts/apidefs.h.in:
##########
@@ -1650,10 +1650,10 @@ struct TSResponseAction {
};
enum TSLogType {
- TS_LOG_TYPE_INT,
+ TS_LOG_TYPE_INT = 1, ///< LogField::Type::sINT
// DINT is omitted from the public API for now, until we decide whether we
keep the type
- TS_LOG_TYPE_STRING = 2,
- TS_LOG_TYPE_ADDR = 3,
+ TS_LOG_TYPE_STRING = 3, ///< LogField::Type::STRING
+ TS_LOG_TYPE_ADDR = 4, ///< LogField::Type::IP
};
Review Comment:
This renumbering is fine because `TSLogType` is going to be released by
11.0.0, it's not published yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
