masaori335 commented on code in PR #13231:
URL: https://github.com/apache/trafficserver/pull/13231#discussion_r3379335206
##########
src/proxy/logging/Log.cc:
##########
@@ -740,58 +758,59 @@ Log::init_fields()
SQUID_MISS_ERROR, "MISS_ERROR",
SQUID_MISS_CACHE_BYPASS, "MISS_CACHE_BYPASS",
SQUID_HIT_MISS_INVALID_ASSIGNED_CODE,
"INVALID_CODE");
- field = new LogField("cache_result_code", "crc", LogField::sINT,
&LogAccess::marshal_cache_result_code,
+ field = new LogField("cache_result_code", "crc", LogField::Type::sINT,
&LogAccess::marshal_cache_result_code,
&LogAccess::unmarshal_cache_code,
make_alias_map(cache_code_map));
global_field_list.add(field, false);
field_symbol_hash.emplace("crc", field);
// Reuse the unmarshalling code from crc
- field = new LogField("cache_result_subcode", "crsc", LogField::sINT,
&LogAccess::marshal_cache_result_subcode,
+ field = new LogField("cache_result_subcode", "crsc", LogField::Type::sINT,
&LogAccess::marshal_cache_result_subcode,
&LogAccess::unmarshal_cache_code,
make_alias_map(cache_subcode_map));
global_field_list.add(field, false);
field_symbol_hash.emplace("crsc", field);
- field = new LogField("cache_hit_miss", "chm", LogField::sINT,
&LogAccess::marshal_cache_hit_miss,
+ field = new LogField("cache_hit_miss", "chm", LogField::Type::sINT,
&LogAccess::marshal_cache_hit_miss,
&LogAccess::unmarshal_cache_hit_miss,
make_alias_map(cache_hit_miss_map));
global_field_list.add(field, false);
field_symbol_hash.emplace("chm", field);
- field = new LogField("proxy_response_all_header_fields", "psah",
LogField::STRING,
+ field = new LogField("proxy_response_all_header_fields", "psah",
LogField::Type::STRING,
&LogAccess::marshal_proxy_resp_all_header_fields,
&LogUtils::unmarshalMimeHdr);
global_field_list.add(field, false);
field_symbol_hash.emplace("psah", field);
// proxy -> server fields
- field = new LogField("proxy_req_header_len", "pqhl", LogField::sINT,
&LogAccess::marshal_proxy_req_header_len,
+ field = new LogField("proxy_req_header_len", "pqhl", LogField::Type::sINT,
&LogAccess::marshal_proxy_req_header_len,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("pqhl", field);
- field = new LogField("proxy_req_squid_len", "pqql", LogField::sINT,
&LogAccess::marshal_proxy_req_squid_len,
+ field = new LogField("proxy_req_squid_len", "pqql", LogField::Type::sINT,
&LogAccess::marshal_proxy_req_squid_len,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("pqql", field);
- field = new LogField("proxy_req_content_len", "pqcl", LogField::sINT,
&LogAccess::marshal_proxy_req_content_len,
+ field = new LogField("proxy_req_content_len", "pqcl", LogField::Type::sINT,
&LogAccess::marshal_proxy_req_content_len,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("pqcl", field);
- field = new LogField("proxy_req_server_ip", "pqsi", LogField::IP,
&LogAccess::marshal_proxy_req_server_ip,
+ field = new LogField("proxy_req_server_ip", "pqsi", LogField::Type::IP,
&LogAccess::marshal_proxy_req_server_ip,
&LogAccess::unmarshal_ip_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("pqsi", field);
- field = new LogField("proxy_req_server_port", "pqsp", LogField::sINT,
&LogAccess::marshal_proxy_req_server_port,
+ field = new LogField("proxy_req_server_port", "pqsp", LogField::Type::sINT,
&LogAccess::marshal_proxy_req_server_port,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("pqsp", field);
- field = new LogField("next_hop_ip", "nhi", LogField::IP,
&LogAccess::marshal_next_hop_ip, &LogAccess::unmarshal_ip_to_str);
+ field = new LogField("next_hop_ip", "nhi", LogField::Type::IP,
&LogAccess::marshal_next_hop_ip, &LogAccess::unmarshal_ip_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("nhi", field);
- field = new LogField("next_hop_port", "nhp", LogField::IP,
&LogAccess::marshal_next_hop_port, &LogAccess::unmarshal_int_to_str);
+ field =
+ new LogField("next_hop_port", "nhp", LogField::Type::IP,
&LogAccess::marshal_next_hop_port, &LogAccess::unmarshal_int_to_str);
Review Comment:
Seems another bug of unmatched type.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
