masaori335 commented on code in PR #13231:
URL: https://github.com/apache/trafficserver/pull/13231#discussion_r3449280880
##########
src/proxy/logging/Log.cc:
##########
@@ -977,118 +1000,119 @@ Log::init_fields()
Ptr<LogFieldAliasTable> cache_write_code_map = make_ptr(new
LogFieldAliasTable);
cache_write_code_map->init(N_LOG_CACHE_WRITE_TYPES, LOG_CACHE_WRITE_NONE,
"-", LOG_CACHE_WRITE_LOCK_MISSED, "WL_MISS",
LOG_CACHE_WRITE_LOCK_ABORTED, "INTR",
LOG_CACHE_WRITE_ERROR, "ERR", LOG_CACHE_WRITE_COMPLETE, "FIN");
- field = new LogField("cache_write_result", "cwr", LogField::sINT,
&LogAccess::marshal_cache_write_code,
+ field = new LogField("cache_write_result", "cwr", LogField::Type::sINT,
&LogAccess::marshal_cache_write_code,
&LogAccess::unmarshal_cache_write_code,
make_alias_map(cache_write_code_map));
global_field_list.add(field, false);
field_symbol_hash.emplace("cwr", field);
- field = new LogField("cache_write_transform_result", "cwtr", LogField::sINT,
&LogAccess::marshal_cache_write_transform_code,
+ field = new LogField("cache_write_transform_result", "cwtr",
LogField::Type::sINT, &LogAccess::marshal_cache_write_transform_code,
&LogAccess::unmarshal_cache_write_code,
make_alias_map(cache_write_code_map));
global_field_list.add(field, false);
field_symbol_hash.emplace("cwtr", field);
// other fields
- field = new LogField("transfer_time_ms", "ttms", LogField::sINT,
&LogAccess::marshal_transfer_time_ms,
+ field = new LogField("transfer_time_ms", "ttms", LogField::Type::sINT,
&LogAccess::marshal_transfer_time_ms,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("ttms", field);
- field = new LogField("transfer_time_ms_hex", "ttmsh", LogField::sINT,
&LogAccess::marshal_transfer_time_ms,
+ field = new LogField("transfer_time_ms_hex", "ttmsh", LogField::Type::sINT,
&LogAccess::marshal_transfer_time_ms,
&LogAccess::unmarshal_int_to_str_hex);
global_field_list.add(field, false);
field_symbol_hash.emplace("ttmsh", field);
- field = new LogField("transfer_time_ms_fractional", "ttmsf", LogField::sINT,
&LogAccess::marshal_transfer_time_ms,
+ field = new LogField("transfer_time_ms_fractional", "ttmsf",
LogField::Type::sINT, &LogAccess::marshal_transfer_time_ms,
&LogAccess::unmarshal_ttmsf);
global_field_list.add(field, false);
field_symbol_hash.emplace("ttmsf", field);
- field =
- new LogField("transfer_time_sec", "tts", LogField::sINT,
&LogAccess::marshal_transfer_time_s, &LogAccess::unmarshal_int_to_str);
+ field = new LogField("transfer_time_sec", "tts", LogField::Type::sINT,
&LogAccess::marshal_transfer_time_s,
+ &LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("tts", field);
- field = new LogField("file_size", "fsiz", LogField::sINT,
&LogAccess::marshal_file_size, &LogAccess::unmarshal_int_to_str);
+ field = new LogField("file_size", "fsiz", LogField::Type::sINT,
&LogAccess::marshal_file_size, &LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("fsiz", field);
- field = new LogField("client_connection_id", "ccid", LogField::sINT,
&LogAccess::marshal_client_http_connection_id,
+ field = new LogField("client_connection_id", "ccid", LogField::Type::sINT,
&LogAccess::marshal_client_http_connection_id,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("ccid", field);
- field = new LogField("client_transaction_id", "ctid", LogField::sINT,
&LogAccess::marshal_client_http_transaction_id,
+ field = new LogField("client_transaction_id", "ctid", LogField::Type::sINT,
&LogAccess::marshal_client_http_transaction_id,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("ctid", field);
- field = new LogField("cache_read_retry_attempts", "crra", LogField::sINT,
&LogAccess::marshal_cache_read_retries,
+ field = new LogField("cache_read_retry_attempts", "crra",
LogField::Type::sINT, &LogAccess::marshal_cache_read_retries,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("crra", field);
- field = new LogField("cache_write_retry_attempts", "cwra", LogField::sINT,
&LogAccess::marshal_cache_write_retries,
+ field = new LogField("cache_write_retry_attempts", "cwra",
LogField::Type::sINT, &LogAccess::marshal_cache_write_retries,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("cwra", field);
- field = new LogField("cache_collapsed_connection_success", "cccs",
LogField::sINT,
+ field = new LogField("cache_collapsed_connection_success", "cccs",
LogField::Type::sINT,
&LogAccess::marshal_cache_collapsed_connection_success,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("cccs", field);
- field = new LogField("client_transaction_priority_weight", "ctpw",
LogField::sINT,
+ field = new LogField("client_transaction_priority_weight", "ctpw",
LogField::Type::sINT,
&LogAccess::marshal_client_http_transaction_priority_weight,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("ctpw", field);
- field = new LogField("client_transaction_priority_dependence", "ctpd",
LogField::sINT,
+ field = new LogField("client_transaction_priority_dependence", "ctpd",
LogField::Type::sINT,
&LogAccess::marshal_client_http_transaction_priority_dependence,
&LogAccess::unmarshal_int_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("ctpd", field);
- field = new LogField("proxy_protocol_version", "ppv", LogField::STRING,
&LogAccess::marshal_proxy_protocol_version,
+ field = new LogField("proxy_protocol_version", "ppv",
LogField::Type::STRING, &LogAccess::marshal_proxy_protocol_version,
&LogAccess::unmarshal_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("ppv", field);
- field = new LogField("proxy_protocol_src_ip", "pps", LogField::IP,
&LogAccess::marshal_proxy_protocol_src_ip,
+ field = new LogField("proxy_protocol_src_ip", "pps", LogField::Type::IP,
&LogAccess::marshal_proxy_protocol_src_ip,
&LogAccess::unmarshal_ip_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("ppsip", field);
- field = new LogField("proxy_protocol_dst_ip", "ppd", LogField::IP,
&LogAccess::marshal_proxy_protocol_dst_ip,
+ field = new LogField("proxy_protocol_dst_ip", "ppd", LogField::Type::IP,
&LogAccess::marshal_proxy_protocol_dst_ip,
&LogAccess::unmarshal_ip_to_str);
global_field_list.add(field, false);
field_symbol_hash.emplace("ppdip", field);
Review Comment:
Pre-exiting issue prior to this change. I'll fix it in other PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
