bneradt commented on code in PR #13213:
URL: https://github.com/apache/trafficserver/pull/13213#discussion_r3365964972
##########
src/iocore/net/quic/QUICStreamAdapter.cc:
##########
@@ -26,7 +26,12 @@
Ptr<IOBufferBlock>
QUICStreamAdapter::read(size_t len)
{
- auto ret = this->_read(len);
+ return this->_read(len);
+}
+
+void
+QUICStreamAdapter::consume(size_t len)
+{
+ this->_consume(len);
Review Comment:
QUICStreamAdapter::read() is now a peek-style read, and direct draining
callers consume explicitly: TestQUICStream::read() in test_QPACK.cc calls
consume(nread), while QUICStream::send_data() consumes only the bytes accepted
by quiche.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
