maskit commented on code in PR #13213: URL: https://github.com/apache/trafficserver/pull/13213#discussion_r3422521581
########## include/proxy/http3/Http3Transaction.h: ########## @@ -106,7 +114,12 @@ class HQTransaction : public ProxyTransaction Event *_write_ready_event = nullptr; Event *_write_complete_event = nullptr; - bool _transaction_done = false; + bool _transaction_done = false; + bool _event_handler_active = false; + bool _closed = false; + bool _stream_closed = false; Review Comment: I don't like these closed flags. I know H2 has similar ones, but those are just confusing. Places that needs these flags should consider checking QUIC stream state. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
