bneradt commented on code in PR #13213:
URL: https://github.com/apache/trafficserver/pull/13213#discussion_r3366370739
##########
src/proxy/http3/Http3App.cc:
##########
@@ -131,6 +131,10 @@ Http3App::on_stream_open(QUICStream &stream)
void
Http3App::on_stream_close(QUICStream &stream)
{
+ if (auto *txn = this->_ssn->get_transaction(stream.id()); txn != nullptr) {
+ SCOPED_MUTEX_LOCK(lock, txn->mutex, this_ethread());
+ txn->stream_closed();
+ }
this->_streams.erase(stream.id());
Review Comment:
Http3App::on_stream_close() now installs a cleanup callback on the
transaction while holding the transaction mutex. _streams is only erased
immediately when no transaction exists; otherwise the IOInfo remains alive
until HQTransaction destruction runs the cleanup.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
