JosiahWI commented on code in PR #13262:
URL: https://github.com/apache/trafficserver/pull/13262#discussion_r3403560274
##########
include/tscore/DiagsTypes.h:
##########
@@ -142,14 +222,24 @@ class Diags : public DebugInterface
// non-const initialization inside a function have a hidden flag that is
checked every time the containing
// block is entered, to see if the variable has been initialized or not.
//
+ /// @brief Returns true if diagnostic output is globally enabled for mode.
+ ///
+ /// @param mode DiagsTagType_Debug or DiagsTagType_Action.
+ /// @return true if output for mode is enabled (globally or via IP override).
+ /// @note This is the fast-path check. It does not perform tag matching.
+ /// Thread-safe; reads atomic state without acquiring the internal
lock.
bool
on(DiagsTagType mode = DiagsTagType_Debug) const
{
return (config.enabled(mode) & 1) || (config.enabled(mode) == 2 &&
this->get_override());
}
- // Returns true if tag is enabled for mode.
- //
+ /// @brief Returns true if the given tag is enabled for mode.
+ ///
+ /// @param tag Tag string to check. Must not be nullptr.
Review Comment:
Correct. 👍
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
