JosiahWI commented on code in PR #13262:
URL: https://github.com/apache/trafficserver/pull/13262#discussion_r3403605510


##########
include/tscore/DiagsTypes.h:
##########
@@ -220,26 +383,150 @@ class Diags : public DebugInterface
     va_end(ap);
   }
 
+  /// @brief Variadic implementation of error().
+  ///
+  /// @param level Diagnostic severity level.
+  /// @param loc Optional source location. May be nullptr.
+  /// @param fmt printf-style format string.
+  /// @param ap Argument list for fmt.
+  /// @post Message is written. Process exits if level is terminal.
+  /// @note Thread-safe for the output step. Virtual to allow test overrides.
   virtual void error_va(DiagsLevel level, const SourceLocation *loc, const 
char *fmt, va_list ap) const;
 
+  /// @brief Writes a human-readable summary of the current Diags 
configuration.
+  ///
+  /// @param fp Output FILE stream. Defaults to stdout.
+  /// @pre fp must be a valid open stream.
+  /// @post A formatted table of enabled states, tag patterns, and output
+  ///       routing is written to fp.
+  /// @note Not intended for production code paths. Configuration is read
+  ///       without the internal lock; output is informational only.
   void dump(FILE *fp = stdout) const;
 
+  /// @brief Replaces the active tag filter with the compiled form of taglist.
+  ///
+  /// @param taglist Vertical-bar-separated regex pattern (e.g., "http|dns"),
+  ///        or nullptr to clear the active pattern.
+  /// @param mode DiagsTagType_Debug or DiagsTagType_Action.

Review Comment:
   Correct. 👍 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to