JosiahWI commented on code in PR #13262: URL: https://github.com/apache/trafficserver/pull/13262#discussion_r3403566423
########## include/tscore/DiagsTypes.h: ########## @@ -160,10 +250,24 @@ class Diags : public DebugInterface // low-level tag inquiry functions // ///////////////////////////////////// - // This does regex match against the tag. - // + /// @brief Returns true if tag matches the active regex for mode. + /// + /// @param tag Tag string to match. If nullptr, returns true unconditionally. + /// @param mode DiagsTagType_Debug or DiagsTagType_Action. + /// @return true if tag matches the compiled regex, or if no regex is set, or + /// if tag is nullptr. Review Comment: Correct. 👍 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
