Copilot commented on code in PR #13278:
URL: https://github.com/apache/trafficserver/pull/13278#discussion_r3416702149
##########
src/api/InkContInternal.cc:
##########
@@ -157,8 +157,12 @@ INKContInternal::handle_event(int event, void *edata)
/* set the plugin context */
auto *previousContext = pluginThreadContext;
pluginThreadContext = reinterpret_cast<PluginThreadContext *>(m_context);
- int retval = m_event_func((TSCont)this, (TSEvent)event, edata);
- pluginThreadContext = previousContext;
+ // All plugin hook/callback dispatches flow through here; count this one
against the plugin.
Review Comment:
This comment is not accurate: remap plugin dispatch (e.g.
`RemapPlugins::run_plugin`) does not flow through
`INKContInternal::handle_event`. Consider narrowing the wording so it
specifically refers to TSCont/continuation callback dispatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
