moonchen commented on code in PR #13278:
URL: https://github.com/apache/trafficserver/pull/13278#discussion_r3439585205
##########
src/proxy/Plugin.cc:
##########
@@ -215,7 +243,17 @@ single_plugin_init(int argc, char *argv[], bool
validateOnly)
#endif
opterr = 0;
optarg = nullptr;
+
+ // Install this plugin's context around TSPluginInit so the continuations
it creates carry its
+ // identity (see GlobalPluginContext).
+ auto *global_context = new GlobalPluginContext(path);
+ g_global_plugin_contexts.push_back(global_context);
+ auto *prev_plugin_context = pluginThreadContext;
+ pluginThreadContext = global_context;
+
init(argc, argv);
+
+ pluginThreadContext = prev_plugin_context;
Review Comment:
Done in 714abbbf8c — moved `registerPluginMetrics` (and its token helper)
inline into `PluginDso.h`, so `GlobalPluginContext` in `ts::proxy` resolves it
locally and no longer references the out-of-line symbol in `ts::http_remap`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
