Copilot commented on code in PR #13278:
URL: https://github.com/apache/trafficserver/pull/13278#discussion_r3439117178
##########
src/proxy/PluginVC.cc:
##########
@@ -522,6 +528,11 @@ PluginVC::process_write_side()
return;
}
+ // Past this point there is data to move: count a write-side pass for the
owning plugin
+ if (core_obj->_transfers != nullptr) {
+ core_obj->_transfers->increment(1);
+ }
+
Review Comment:
`_transfers` is incremented before verifying the peer VIO can accept any
data. If `other_ntodo == 0`, this path returns without moving bytes, but still
counts a "transfer". Move the increment to after the `other_ntodo` check (and
after `act_on` is clamped) so `transfers` better reflects actual data-move
passes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
