bneradt commented on code in PR #13213: URL: https://github.com/apache/trafficserver/pull/13213#discussion_r3532274751
########## include/proxy/http3/Http3Transaction.h: ########## @@ -106,7 +114,12 @@ class HQTransaction : public ProxyTransaction Event *_write_ready_event = nullptr; Event *_write_complete_event = nullptr; - bool _transaction_done = false; + bool _transaction_done = false; + bool _event_handler_active = false; + bool _closed = false; + bool _stream_closed = false; Review Comment: Addressed. I removed the _closed and _stream_closed booleans from HQTransaction. The transaction closed state is now derived from the transaction continuation handler, and the QUIC stream closed state is derived from the QUICStreamVCAdapter handler. I verified this against both BoringSSL+quiche and OpenSSL native QUIC H3 AuTests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
