grahamsedman commented on PR #13187: URL: https://github.com/apache/trafficserver/pull/13187#issuecomment-5060017822
Hi, Before I go ahead and split this PR, I wanted to point out something I noticed. It looks like lib/swoc is a downstream copy of the upstream trafficserver-libswoc repo (currently at v1.5.15 here, while upstream is at v1.5.17). Since this bug is in the core TextView constructors, should I be opening a PR against the upstream trafficserver-libswoc repository first to fix the root cause there? If I fix it upstream, the 'fix' for this ATS PR would simply be updating the lib/swoc submodule pointer to include the upstream patch (along with the unit test) as two pull requests on non-functional and one functional. I'm happy to do whichever workflow you prefer! Just wanted to make sure we aren't fixing something here that will get overwritten when ATS updates to a newer version of libswoc. Thanks Graham -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
