JosiahWI commented on code in PR #13420:
URL: https://github.com/apache/trafficserver/pull/13420#discussion_r3674277938
##########
include/proxy/http/HttpSM.h:
##########
@@ -707,13 +730,30 @@ HttpSM::get_cache_sm()
inline int
HttpSM::write_response_header_into_buffer(HTTPHdr *h, MIOBuffer *b)
{
- if (t_state.client_info.http_version == HTTPVersion(0, 9)) {
+ if (_ua.get_txn()->supports_direct_header_passing()) {
+ // Nothing lands in the buffer, so 0 keeps the tunnel's byte math honest.
+ _client_response_header_is_ready = true;
+ _direct_response_hdr_bytes = h->length_get();
+ return 0;
+ } else if (t_state.client_info.http_version == HTTPVersion(0, 9)) {
return 0;
Review Comment:
Is this a dead code path now? Can we remove it?
##########
include/proxy/http2/Http2Stream.h:
##########
@@ -81,7 +81,14 @@ class Http2Stream : public ProxyTransaction
bool expect_receive_trailer() const override;
void set_expect_receive_trailer() override;
+ bool supports_direct_header_passing() const override;
+ bool is_parsed_receive_header_ready() const override;
+ const HTTPHdr *parsed_receive_header() const override;
+ bool has_pending_send_header() const override;
+
Http2ErrorCode decode_header_blocks(HpackHandle &hpack_handle, uint32_t
maximum_table_size);
+ Http2ErrorCode decode_header_blocks(HpackHandle &hpack_handle, uint32_t
maximum_table_size, const uint8_t *block,
Review Comment:
Nitpick: you could consider using `std::span` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
