zwoop commented on PR #13420: URL: https://github.com/apache/trafficserver/pull/13420#issuecomment-5880382679
@bryancall Thanks for the review. Rebased on master and addressed your comments in df68c52d66: - Removed `http2_fc_iso.test.py`. - Added a negative test for each fast-path check (userinfo in `:authority`, non-token method, bad Content-Length, non-printable path, oversized header field, and a request line over `request_line_max_size`). - Rather than documenting the `request_line_max_size` gap, the fast path now falls back to `parse_req` near the request line and header field limits, so HTTP/2 matches HTTP/1.1. - Fixed the three smaller items: `clear_pending_send_header()` is per direction, header byte counts are right with prewarm, and `:authority` is copied out before `url_parse_internet()` allocates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
