zwoop commented on code in PR #13420: URL: https://github.com/apache/trafficserver/pull/13420#discussion_r4128115270
########## tests/gold_tests/h2/h2_outbound_request_handling.test.py: ########## @@ -0,0 +1,27 @@ +''' +Verify HTTP/2 outbound (SM -> origin) server-request handling: the request +header is handed to the outbound stream without a serialize+reparse. +''' +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. Review Comment: This follows the existing layout in tests/gold_tests/h2, where 22 tests (including recent additions) put the module docstring first and the license block right after it. A module docstring has to be the first statement. ########## tests/gold_tests/h2/h2_request_handling.test.py: ########## @@ -0,0 +1,28 @@ +''' +Verify HTTP/2 client request handling through the fast-path handoff to HttpSM. +''' +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, software +# distributed under the License is distributed on an "AS IS" BASIS, +# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. +# See the License for the specific language governing permissions and +# limitations under the License. Review Comment: This follows the existing layout in tests/gold_tests/h2, where 22 tests (including recent additions) put the module docstring first and the license block right after it. A module docstring has to be the first statement. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
