bneradt commented on PR #13545: URL: https://github.com/apache/trafficserver/pull/13545#issuecomment-5334843406
Thanks for the detailed review. I addressed the feedback and force-pushed the amended commit. - Removed both unrelated production changes from this PR. The max-stale percentage feature landed separately in #13547. The converted certificate-update scenario is now a strict expected failure for the pre-existing `TSSslClientCertUpdate` defect, which can be fixed separately. - Updated the Jenkins, coverage, and regression scripts to invoke Uranium and use pytest's `-k` and `-n` options. - Kept this as an intentional clean cutover rather than an AuTest compatibility shim. Removed AuTest CMake variables now produce explicit migration errors, and I updated the PR description accordingly. - Changed automatic execution to avoid nested Docker in any detected container, while retaining the explicit Docker override flags. - Changed metric checks to poll until their deadline. - Added explicit assertions for missing actual, gold, and diagnostic files. - Renamed the framework's local `RuntimeError` to `RuntimeConfigError`. I also normalized direct replay placement, fixed the stale documentation includes, and reran the relevant validation: the documentation build passes with warnings treated as errors, all 371 replay variants passed or reached expected capability skips, and the 51 framework unit tests pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
