bneradt commented on PR #13545: URL: https://github.com/apache/trafficserver/pull/13545#issuecomment-5736600706
@bryancall Rebased onto current master, `281b608361`, and force-pushed `57c0465079`. The branch now contains that master revision, with the merge conflict resolved. The rebase carried over the updated per-server metric coverage from #13666: the `current_connection.max` name, aggregation mode 3 for sums plus max, exclusion of hidden per-group metrics, and the new runtime retraction case. The Uranium scenario verifies that previously published group metrics disappear when switching from mode 0 to max-only mode 2, and that hostname sums are absent. It waits for the behavior to take effect while recreating drained connection groups. I also adapted master's new process-lifetime review guidance to Uranium's fixture ownership. Validation on the rebased tree in asfats5: ATS build/install and the full formatting target passed; all 73 framework tests passed; all 145 selected C++ tests passed through CTest; and all three origin-connection scenarios passed with `-n 4`, including the expanded per-server test. These are local results; the new CI run still needs to complete. The substantive conversion delta from the previous pushed head is in `test_per_server_connection_max.py` and `.github/copilot-instructions.md`; the remaining changes between those heads come from master. Ready for your delta re-review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
