Copilot commented on code in PR #13545:
URL: https://github.com/apache/trafficserver/pull/13545#discussion_r4157580325
##########
ci/rat-exclude.txt:
##########
@@ -76,8 +76,8 @@ blib/**
**/systemtap/**
**/swoc/**
**/highway/**
-tests/gold_tests/autest-site/min_cfg
-tests/gold_tests/h2/rules/huge_resp_hdrs.conf
+tests/uranium_tests/autest-site/min_cfg
Review Comment:
This exclusion now points at `tests/uranium_tests/autest-site/min_cfg`, but
that directory does not exist; the new unlicensed fixture files are under
`tests/tools/uranium/min_cfg`. RAT will therefore scan these files and can fail
the license check. Point the exclusion at the actual directory.
##########
CMakeLists.txt:
##########
@@ -162,8 +162,11 @@ option(ENABLE_DISK_FAILURE_TESTS "Build disk failure tests
(enables AIO fault in
if(ENABLE_DISK_FAILURE_TESTS)
add_compile_definitions("AIO_FAULT_INJECTION")
endif()
-option(ENABLE_AUTEST "Setup autest (default OFF)")
-option(ENABLE_AUTEST_UDS "Setup autest with curl using UDS (default OFF)")
+option(ENABLE_URTEST "Set up Uranium tests (default OFF)")
+option(ENABLE_URTEST_UDS "Set up Uranium tests with curl using UDS (default
OFF)")
+if(DEFINED ENABLE_AUTEST OR DEFINED ENABLE_AUTEST_UDS)
+ message(FATAL_ERROR "ENABLE_AUTEST and ENABLE_AUTEST_UDS were removed; use
ENABLE_URTEST and ENABLE_URTEST_UDS")
Review Comment:
This fatal guard now breaks the existing
`contrib/docker/ubuntu/resolute/Dockerfile`, which still configures CMake with
`-DENABLE_AUTEST=OFF`. Update that image recipe (and any other remaining
callers) to the new `ENABLE_URTEST` option before making the legacy variable an
unconditional configuration error.
This issue also appears on line 864 of the same file.
##########
doc/developer-guide/api/functions/TSHttpHookAdd.en.rst:
##########
@@ -146,7 +146,7 @@ transaction hooks::
}
For more example code using hooks, see the test_hooks plugin in
tests/tools/plugins (used by the test_hooks.test.py
-Gold test).
+Uranium test).
Review Comment:
The edit leaves the sentence as “used by the test_hooks.test.py Uranium
test”, which is grammatically malformed and still contains the old test
filename. Update the sentence to name the migrated test correctly.
##########
doc/developer-guide/testing/config-reload-ext.en.rst:
##########
@@ -27,7 +27,7 @@ replace the legacy pattern of fire-and-forget ``traffic_ctl
config reload``
followed by log grepping with a deterministic, structured approach.
The extension is loaded automatically from
-``tests/gold_tests/autest-site/config_reload.test.ext``.
+``tests/uranium_tests/autest-site/config_reload.test.ext``.
Review Comment:
This documentation now points to
`tests/uranium_tests/autest-site/config_reload.test.ext`, but that file and
directory are absent from the tree. The page therefore documents a loader path
that cannot work after the AuTest cutover; remove or rewrite this extension
section around the actual Uranium reload tests.
##########
plugins/experimental/jax_fingerprint/README:
##########
@@ -158,6 +158,6 @@ Unit tests vs. AuTest
algorithm logic. Built when BUILD_TESTING is on; run via ctest or the
test_jax binary directly.
- * End-to-end AuTests live under
`tests/gold_tests/pluginTest/jax_fingerprint/`
+ * End-to-end AuTests live under
`tests/uranium_tests/pluginTest/jax_fingerprint/`
Review Comment:
This still labels the migrated suite as “AuTests” even though it now lives
under Uranium and the PR removes the AuTest backend. Rename the reference so
this README does not direct readers to a nonexistent test system.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
