bneradt commented on code in PR #13613:
URL: https://github.com/apache/trafficserver/pull/13613#discussion_r3908092041


##########
plugins/lua/ts_lua_stat.cc:
##########
@@ -18,22 +18,19 @@
 
 #include "ts_lua_util.h"
 
-typedef enum {
-  TS_LUA_STAT_PERSISTENT     = TS_STAT_PERSISTENT,
-  TS_LUA_STAT_NON_PERSISTENT = TS_STAT_NON_PERSISTENT
-} TSLuaStatPersistentType;
+enum TSLuaStatPersistentType { TS_LUA_STAT_PERSISTENT = TS_STAT_PERSISTENT, 
TS_LUA_STAT_NON_PERSISTENT = TS_STAT_NON_PERSISTENT };

Review Comment:
   Thanks. The line was under the 132-character limit, but keeping this enum 
multi-line is clearer and consistent with the neighboring declarations. I added 
local clang-format off/on markers because AllowShortEnumsOnASingleLine 
otherwise collapses it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to