cmcfarlen commented on code in PR #13613:
URL: https://github.com/apache/trafficserver/pull/13613#discussion_r3918686896
##########
plugins/regex_revalidate/regex_revalidate.cc:
##########
@@ -110,23 +110,23 @@ strForResult(TSCacheLookupResult const result)
}
}
-typedef struct invalidate_t {
+using invalidate_t = struct invalidate_t {
Review Comment:
especially this one since the name is the same anyway.
##########
plugins/healthchecks/healthchecks.cc:
##########
@@ -48,11 +48,11 @@ static DbgCtl dbg_ctl{PLUGIN_NAME};
#define MAX_BODY_LEN 16384
/* Directories that we are watching for inotify IN_CREATE events. */
-typedef struct HCDirEntry_t {
+using HCDirEntry = struct HCDirEntry_t {
Review Comment:
Unless this is also referred to by the `_t` name, maybe the better cleanup
here is to just fix the struct name and not have the using?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
