bneradt commented on code in PR #13613:
URL: https://github.com/apache/trafficserver/pull/13613#discussion_r3919097508


##########
plugins/healthchecks/healthchecks.cc:
##########
@@ -48,11 +48,11 @@ static DbgCtl dbg_ctl{PLUGIN_NAME};
 #define MAX_BODY_LEN 16384
 
 /* Directories that we are watching for inotify IN_CREATE events. */
-typedef struct HCDirEntry_t {
+using HCDirEntry = struct HCDirEntry_t {

Review Comment:
   Agreed. HCDirEntry_t was not used directly, so I named the struct HCDirEntry 
and removed the redundant alias.



##########
plugins/regex_revalidate/regex_revalidate.cc:
##########
@@ -110,23 +110,23 @@ strForResult(TSCacheLookupResult const result)
   }
 }
 
-typedef struct invalidate_t {
+using invalidate_t = struct invalidate_t {

Review Comment:
   Agreed. Since the struct and alias already had the same name, I removed the 
redundant alias and kept invalidate_t as the struct name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to