brbzull0 opened a new pull request, #13649:
URL: https://github.com/apache/trafficserver/pull/13649

   A failing assertion inside a SECTION reports twice. Catch2 re-runs the 
TEST_CASE body once per SECTION, and the trailing test_remove_handler() never 
runs when a fatal REQUIRE unwinds first, so the handler survives into the next 
run and its add_method_handler() fails as well. The second failure points at a 
registration that was never the problem.
   
   Tie registration to a scope guard instead, so the handler is removed on the 
way out however the body exits. The concurrent-request case never removed its 
two handlers at all, and never checked that registering them worked; it uses 
the guard now as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to