bneradt commented on PR #13652: URL: https://github.com/apache/trafficserver/pull/13652#issuecomment-5591638053
Amended and force-pushed as 3f5cfa1315. The source comment about PCRE history is removed, and the commit and PR description now explain the original stack-protection limit, the conversion mistake, and why this fix retains PCRE2's defaults. AI attribution now explicitly reads `Co-authored-by: Codex Astra Medium`. PCRE2 does have a depth limit: `pcre2_set_depth_limit()` controls nested backtracking in the interpreter, and its normal default is 10 million (build-time configurable). Since PCRE2 10.30, interpreter backtracking frames reside on the heap, so the old PCRE stack-derived value of 1750 does not carry over as a stack-protection requirement. JIT ignores the depth limit and uses a separately bounded stack; regex_remap's match context retains the default 32 KiB JIT stack. This patch removes only the accidental work-limit override. It does not remove the existing depth, heap, or JIT-stack limits. References: [PCRE2 API and depth limits](https://pcre2project.github.io/pcre2/doc/pcre2api/), [JIT stack limits](https://pcre2project.github.io/pcre2/doc/pcre2jit/). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
