bneradt commented on PR #13652: URL: https://github.com/apache/trafficserver/pull/13652#issuecomment-5593158822
@bryancall Addressed in amended commit dccd8f0658: - Removed the per-instance match context and context arguments. The plugin now uses ATS's thread-local Regex context, including its 1 MiB JIT stack. I first changed the 3 KB test to expect its intended 301: it failed against the previous revision with a 200 and `-46`. After the code change, it passes with the expected 301 and Location. The existing redirect gold file is reused; the 200 gold remains for the excessive-backtracking case. - Replaced the blanket error exclusion once with a check permitting only the deliberate `/match_limit/` error, then appended the independent assertions with `+=`. The renamed long-query run excludes matching errors for its rule; the excessive-backtracking run requires `-47` for its own rule. - Qualified the Backport label in the commit and PR description: **10.2.x only, not 10.1.x or 9.2.x**. I checked all three branch implementations. - Documented the regression input's required 2,000-byte suffix and distinguished the token-placement/no-token controls from the backtracking case. Both wording fixes are applied. - Removed ESI's obsolete cross-reference, retaining its independent allowlist work limit. - Kept the historical explanation in the commit/PR rather than restoring a source-history comment, as requested by the PR author. The rationale now cites #6819 and #12575 and explicitly acknowledges the larger worst-case CPU budget. The revised `regex_remap` and `regex_remap_long_query` AuTests both pass in `asfats5`; the deliberate excessive-backtracking case still reports `-47`. Build and formatting checks pass. I filed #13654 for resource-error fallthrough and left that behavioral decision outside this patch. I also updated my earlier PR comment so it no longer describes the obsolete 32 KiB context as the final design. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
