bneradt commented on PR #13652: URL: https://github.com/apache/trafficserver/pull/13652#issuecomment-5604507587
@bryancall Applied the consolidated correction in **new commit 1dee701051**, pushed normally without amending or force-pushing. - `regex_remap.cc` now matches 3f5cfa1315 exactly: the per-instance match context and explicit context arguments are restored, while the 1750 work-limit override remains removed. - The original `/alpha/bravo/` request again uses `gold/regex_remap_crash.gold` and verifies that ATS survives resource exhaustion without redirecting. Its appended diagnostic assertion is tied to that rule and accepts the resource-limit category rather than incorrectly requiring `-47`. - The independent `/match_limit/` assertion still requires `-47`, and the 32-character subject remains. The other review improvements are retained. Both `regex_remap` and `regex_remap_long_query` pass in `asfats5`, as do the build and formatting checks. The restored crash guard reports `-46` with a 200 response; the separate work-limit case reports `-47`; the ordinary long-query redirects pass. I updated the PR title, description, and earlier scope comment to distinguish the conversion regression from the pre-existing crash-guard behavior. The shared-context change is left for your separate PR, and the backport scope remains 10.2.x only. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
