masaori335 opened a new pull request, #13675:
URL: https://github.com/apache/trafficserver/pull/13675
`modifiers: [NOT]` only caught an explicit `with NOT`, and `language: [in]`
only caught the `[...]` value form, so `!expr`, `!=`, `!~`, `!in` and `in
{10.0.0.0/8}` all compiled unchecked. AND and OR were already checked at `&&`
and `||`; negation and IP-range membership are now consistent with that.
The check sits at the two sites where the source introduces negation, not at
`_make_condition`, whose `negate` argument is also true for the `[NOT]` the
compiler synthesises for a bare header test. Denying `NOT` must not reject `if
inbound.req.X-Foo`; allowed-implicit-not pins that.
`modifiers` was undocumented, so the sandbox section gains it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
