masaori335 commented on code in PR #13675:
URL: https://github.com/apache/trafficserver/pull/13675#discussion_r4010414320
##########
doc/admin-guide/configuration/hrw4u.en.rst:
##########
@@ -778,9 +779,24 @@ Construct What it controls
``variables`` The entire ``VARS`` section and all variable usage
``else`` The ``else { ... }`` branch of conditionals
``elif`` The ``elif ... { ... }`` branch of conditionals
-``in`` The ``in [...]`` and ``!in [...]`` set membership operators
+``in`` Set membership: the ``[...]`` value form and
+ the ``{...}`` IP range form, negated or not
================ ===================================================
+Condition Modifiers
+-------------------
+
+The ``modifiers`` list accepts ``AND``, ``OR``, ``NOT``, ``NOCASE``, ``PRE``,
+``SUF``, ``EXT``, ``MID``, ``I``, ``L`` and ``QSA``. Entries match the modifier
+however it is written, not only the explicit ``with`` form: ``AND`` also covers
+``&&``, ``OR`` also covers ``||``, and ``NOT`` also covers ``!``, ``!=``,
+``!~`` and ``!in``.
+
+Negation that the compiler introduces on its own is not matched. A bare header
+test such as ``if inbound.req.X-Foo`` compiles to ``cond %{HEADER:X-Foo} =""
+[NOT]``, and denying ``NOT`` does not reject it — the policy governs what the
+source writes.
Review Comment:
Fixed by
[9e08728](https://github.com/apache/trafficserver/pull/13675/commits/9e0872896e6f9b48786f9e04213cc8a746e9d6c4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
