masaori335 commented on code in PR #13675:
URL: https://github.com/apache/trafficserver/pull/13675#discussion_r4010411524
##########
tools/hrw4u/src/visitor.py:
##########
@@ -1029,6 +1029,9 @@ def visitComparison(self, ctx, *, last: bool = False) ->
None:
else:
negate = operator.symbol.type in (hrw4uParser.NEQ,
hrw4uParser.NOT_TILDE)
+ if negate and not self._sandbox_check(ctx, lambda:
self._sandbox.check_modifier("NOT")):
+ return
Review Comment:
Returning on a denial is the existing contract for a denied construct:
sections (:755),
VARS / SESSION_VARS (:835, :851), else (:986), elif (:993) and in over a
value set (:1057) all do it, and the admin guide says so for sections — "A
denied section
causes the entire block to be rejected; the body is not validated."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
