bryancall commented on code in PR #13749:
URL: https://github.com/apache/trafficserver/pull/13749#discussion_r4147860930
##########
tests/gold_tests/autest-site/trafficserver.test.ext:
##########
@@ -60,14 +60,20 @@ def MakeATSProcess(
dump_runroot=True,
enable_proxy_protocol=False,
enable_proxy_protocol_cp_src=False,
- disable_log_checks=False):
+ disable_log_checks=False,
+ disable_log_rolling=True):
Review Comment:
Fixed the wording in f096d78df1: it now says this sets
`proxy.config.log.rolling_enabled` to 0, which turns rolling off. The default,
1, is time-based rolling only, so the daily roll is all it removes; changing
the interval or offset instead would only move the roll to another hour inside
some test's run.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
##########
tests/gold_tests/autest-site/trafficserver.test.ext:
##########
@@ -60,14 +60,20 @@ def MakeATSProcess(
dump_runroot=True,
enable_proxy_protocol=False,
enable_proxy_protocol_cp_src=False,
- disable_log_checks=False):
+ disable_log_checks=False,
+ disable_log_rolling=True):
"""Create a traffic server process.
:param block_for_debug: if True, causes traffic_server to run with the
--block option enabled, and effectively disables timeouts that could be
triggered by running traffic_server under a debugger. In the debugger,
`set cmd_block = 0`, set any desired break points, then `c` to continue
to let the test proceed.
+
+ :param disable_log_rolling: if True (the default), turn off time-based log
+ rolling, so that a test running across 00:00 UTC does not have its logs
+ renamed before its content checks read them. Pass False to leave the
Review Comment:
Aligned in f096d78df1: the docstring now says it sets `rolling_enabled` to
0, and that the default (1) rolls on a timer only, which is why turning it off
is what stops the midnight roll.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
##########
tests/gold_tests/autest-site/trafficserver.test.ext:
##########
@@ -394,6 +400,12 @@ def MakeATSProcess(
# For config reload tests, no need to wait the default 3 seconds to detect
the need for a reload.
p.Disk.records_config.update({'proxy.config.config_update_interval_ms':
20})
+ # The default time-based log rolling renames every log at 00:00 UTC. A
test that is running
+ # across midnight then checks the fresh, empty file and fails. Tests that
exercise rolling
+ # set this themselves, which overrides the default here.
Review Comment:
Aligned in f096d78df1: the inline comment now describes the default of 1 as
a daily timer at 00:00 UTC and says that 0 turns rolling off.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
##########
tests/gold_tests/autest-site/trafficserver.test.ext:
##########
@@ -394,6 +400,12 @@ def MakeATSProcess(
# For config reload tests, no need to wait the default 3 seconds to detect
the need for a reload.
p.Disk.records_config.update({'proxy.config.config_update_interval_ms':
20})
+ # The default time-based log rolling renames every log at 00:00 UTC. A
test that is running
+ # across midnight then checks the fresh, empty file and fails. Tests that
exercise rolling
+ # set this themselves, which overrides the default here.
+ if disable_log_rolling:
+ p.Disk.records_config.update({'proxy.config.log.rolling_enabled': 0})
Review Comment:
Same fix as the docstring thread, in f096d78df1: the comment says 0 turns
rolling off, and since the default (1) is time-based only, nothing but the
daily roll changes.
_🤖 Addressed by [Claude Code](https://claude.com/claude-code)_
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
