bneradt commented on code in PR #13749:
URL: https://github.com/apache/trafficserver/pull/13749#discussion_r4148072535
##########
tests/gold_tests/autest-site/trafficserver.test.ext:
##########
@@ -394,6 +402,12 @@ def MakeATSProcess(
# For config reload tests, no need to wait the default 3 seconds to detect
the need for a reload.
p.Disk.records_config.update({'proxy.config.config_update_interval_ms':
20})
+ # The default rolling_enabled of 1 rolls every log on a timer, daily at
00:00 UTC. A test
+ # that is running across midnight then checks the fresh, empty file and
fails. 0 turns
+ # rolling off; tests that exercise rolling set rolling_enabled themselves,
overriding this.
Review Comment:
[P3] Keep an active test for explicitly enabled automatic rolling
Non-blocking coverage gap: `log_retention.test.py` has an unconditional
`Test.SkipIf(Condition.true(...))`, and `sigusr2.test.py` explicitly sets
rolling_enabled to 0 and exercises external rotation. Thus those tests do not
verify automatic rolling in a normal suite run. With this default, ordinary log
assertions will also no longer encounter the automatic-rollover path. Consider
a small active regression that explicitly enables automatic rolling after
MakeATSProcess(), drives a controlled roll, and checks both the renamed log and
a subsequent record in the new file. That would preserve intentional coverage
without bringing midnight dependence back into unrelated tests; the existing
tests can remain unchanged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
